Scholarship related #737
Open
Scholarship related #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests passing. manually confirmed UI
…members' table to reflect dues or scholarship
|
This is awesome! Small request to add to this – if someone starts paying dues again (sets up dues) can you terminate the scholarship and record when it ended? 🙏 that's one of the big pain points right now |
|
Oh! That's a good point. I'll take a look at that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves [#468]
Resolved [#346]
What does this code do, and why?
Instead of is_scholarship column, expanded to requested_scholarship, scholarship_since, and scholarship_last_checkin
To facilitate if a scholarship request has been made, but waiting for approval, and to facilitate yearly check-in to see if scholarship to continue.
Since scholarship requests are tracked, can also avoid emails during the new member process when new member is waiting for a scholarship request and hasn't setup dues yet.
How is this code tested?
Are any database migrations required by this change?
Yes.
Because of switch from boolean to timestamp; decided to fill with 2022-07-10 which was around the time of the most recent checkin.
Are there any configuration or environment changes needed?
No.
Screenshots please :)
Admin UI for viewing who's on scholarships:
New member page:
